Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse filewatcher #4475

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

reuse filewatcher #4475

wants to merge 2 commits into from
+178 −430

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Oct 18, 2024

  1. reuse filewatcher package
  2. move code under util

@zirain zirain requested a review from a team as a code owner October 18, 2024 08:13
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 59.49367% with 32 lines in your changes missing coverage. Please review.

Project coverage is 66.01%. Comparing base (f8c7056) to head (4a515d7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/file/file.go 0.00% 26 Missing ⚠️
internal/filewatcher/worker.go 85.71% 2 Missing and 1 partial ⚠️
internal/utils/path/path.go 86.95% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4475      +/-   ##
==========================================
+ Coverage   65.61%   66.01%   +0.40%     
==========================================
  Files         211      209       -2     
  Lines       31961    31774     -187     
==========================================
+ Hits        20970    20977       +7     
+ Misses       9752     9556     -196     
- Partials     1239     1241       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@zirain
Copy link
Contributor Author

zirain commented Oct 18, 2024

cc @shawnh2 PTAL

@arkodg arkodg requested review from shawnh2 and a team October 18, 2024 20:06
shawnh2
shawnh2 reviewed Oct 19, 2024
View reviewed changes
Copy link
Contributor

@shawnh2 shawnh2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done some test, seems running envoy-gateway server -c config.yaml with config.yaml:

apiVersion: gateway.envoyproxy.io/v1alpha1
kind: EnvoyGateway
gateway:
  controllerName: gateway.envoyproxy.io/gatewayclass-controller
provider:
  type: Custom
  custom:
    resource:
      type: File
      file:
        paths: ["test/"]
logging:
  level:
    default: info

cannot catch any modifications (like vim, echo etc) under the paths.

@zirain zirain added the hold do not merge label Oct 19, 2024
@zirain zirain force-pushed the reuse-filewatcher branch 3 times, most recently from dba2ee1 to be0419e Compare October 19, 2024 16:35
@zirain zirain removed the hold do not merge label Oct 20, 2024
@zirain zirain requested a review from shawnh2 October 21, 2024 01:37
@zirain zirain closed this Nov 6, 2024
@zirain zirain reopened this Nov 6, 2024
@zirain
Copy link
Contributor Author

zirain commented Nov 6, 2024

@shawnh2 can you review and test this again?

@shawnh2 shawnh2 added the hold do not merge label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnh2 shawnh2 Awaiting requested review from shawnh2

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
hold do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zirain @shawnh2